Skip to content

C#: Remove cs/non-short-circuit query#651

Closed
hvitved wants to merge 1 commit into
github:masterfrom
hvitved:csharp/remove-non-short-circuit
Closed

C#: Remove cs/non-short-circuit query#651
hvitved wants to merge 1 commit into
github:masterfrom
hvitved:csharp/remove-non-short-circuit

Conversation

@hvitved

@hvitved hvitved commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@hvitved hvitved added the C# label Dec 10, 2018
@hvitved hvitved requested a review from calumgrant December 10, 2018 10:48
@hvitved hvitved requested a review from a team as a code owner December 10, 2018 10:48
@calumgrant

Copy link
Copy Markdown
Contributor

This query could guard other things besides null checks. Therefore, I don't think this query is truly superseded by the nullness queries. It's also quite useful to be told why a nullness query has been triggered, which could be due to a &/&& typo, but it may not be immediately obvious.

@hvitved

hvitved commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

This query could guard other things besides null checks.

In my experience, this query only produces poor results, except for results of the form x != null & x.Foo() and x == null | x.Foo(). Can you think of other good results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants